cl_khr_kernel_clock: use create_single_kernel_helper #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`create_single_kernel_helper` invokes `clBuildProgram` and sets `-cl-std` to the latest version supported by the context. The vast majority of tests are using `create_single_kernel_helper` instead of the `..._create_program` variant, so use the former for the sake of consistency. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
|
@AhmedAmraniAkdi please let me know in case your choice for the |
bashbaug
reviewed
Jun 6, 2024
bashbaug
approved these changes
Jun 9, 2024
AhmedAmraniAkdi
approved these changes
Jun 10, 2024
|
Merging as discussed in the June 18th teleconference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_single_kernel_helperinvokesclBuildProgramand sets-cl-stdto the latest version supported by the context.The vast majority of tests are using
create_single_kernel_helperinstead of the..._create_programvariant, so use the former for the sake of consistency.