math_brute_force: remove spurious tan skip check #1992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `skipTestingRelaxed` check suffers the following problems: - The use of `skipTestingRelaxed` in the `if` seems reversed: when skipping correctness testing using the `-l` command line option, this variable causes correctness testing to be run for relaxed-mode `tan` regardless. - Accuracy testing should only be skipped for derived `tan` implementations. Non-derived `tan` implementations must still be tested for accuracy, so the condition for setting the `skipTestingRelaxed` variable is incomplete. - It is unclear why only `tan` is conditionalized here. There are other functions such as `tanpi` for which one would expect identical behaviour. The actual skipping of accuracy checks for derived implementations happens in `Test()`, so just remove `skipTestingRelaxed` as it does not seem to add any value. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
kpet
approved these changes
Jul 9, 2024
EwanC
approved these changes
Jul 11, 2024
|
Merging as discussed in the July 16th teleconference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
skipTestingRelaxedcheck suffers the following problems:The use of
skipTestingRelaxedin theifseems reversed: when skipping correctness testing using the-lcommand line option, this variable causes correctness testing to be run for relaxed-modetanregardless.Accuracy testing should only be skipped for derived
tanimplementations. Non-derivedtanimplementations must still be tested for accuracy, so the condition for setting theskipTestingRelaxedvariable is incomplete.It is unclear why only
tanis conditionalized here. There are other functions such astanpifor which one would expect identical behaviour.The actual skipping of accuracy checks for derived implementations happens in
Test(), so just removeskipTestingRelaxedas it does not seem to add any value.