math_brute_force: skip all enqueues in -l mode #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The math_brute_force test has a link-check-only mode to quickly test if all math functions are present. In link-check-only mode, most tests return immediately after kernel compilation, but some tests also run the kernel and read back the result data before returning. Running the kernels takes a lot more time, defeating the purpose of the `-l` mode. Break out at the start of the main `for` loops in link-check-only mode instead of returning directly, so that each test can still log its trailing message (in most cases just a `\n`). Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
EwanC
reviewed
Jul 11, 2024
EwanC
approved these changes
Jul 11, 2024
lakshmih
approved these changes
Aug 5, 2024
|
Merging as discussed in the August 6th teleconference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The math_brute_force test has a link-check-only mode to quickly test if all math functions are present.
In link-check-only mode, most tests return immediately after kernel compilation, but some tests also run the kernel and read back the result data before returning. Running the kernels takes a lot more time, defeating the purpose of the
-lmode.Break out at the start of the main
forloops in link-check-only mode instead of returning directly, so that each test can still log its trailing message (in most cases just a\n).