math_brute_force: only test correctly rounded divide/sqrt for fp32 #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lakshmih
previously approved these changes
Jul 29, 2024
Skip the correctly rounded divide (divide_cr) and sqrt (sqrt_cr) tests for fp16 and fp64. The corresponding build option to enable correctly rounded divide and sqrt is named `-cl-fp32-correctly-rounded-divide-sqrt` and the description refers only to "single precision floating-point", so this option should not apply to fp16 or fp64. The specification states that fp16 and fp64 divide and sqrt must be correctly rounded for the full profile, without needing any additional build options. This is already tested by the regular divide and sqrt tests. For the embedded profile the ULP requirement is non-zero, but there is no build option to request a correctly rounded implementation anyway. Fixes KhronosGroup#1901 . Relates to KhronosGroup#1996 . Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
bashbaug
approved these changes
Jul 30, 2024
|
Discussed in the August 6th teleconference. Good to merge offline after @lakshmih 's review. |
lakshmih
approved these changes
Aug 6, 2024
|
Approved in the August 6th teleconference. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip the correctly rounded divide (divide_cr) and sqrt (sqrt_cr) tests for fp16 and fp64.
The corresponding build option to enable correctly rounded divide and sqrt is named
-cl-fp32-correctly-rounded-divide-sqrtand the description refers only to "single precision floating-point", so this option should not apply to fp16 or fp64.The specification states that fp16 and fp64 divide and sqrt must be correctly rounded for the full profile, without needing any additional build options. This is already tested by the regular divide and sqrt tests. For the embedded profile the ULP requirement is non-zero, but there is no build option to request a correctly rounded implementation anyway.
Fixes #1901 .
Relates to #1996 .