Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop linking Vulkan directly #2000

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

ahesham-arm
Copy link
Contributor

@ahesham-arm ahesham-arm commented Jul 4, 2024

The vulkan-wrapper helper library's purpose is to eliminate the need to link targets directly to Vulkan, and load it dynamically instead at runtime, using dlopen and LoadLibrary.

Remove the direct linking of the Vulkan library from targets that link to vulkan-wrapper.

Fixes #1999

The `vulkan-wrapper` helper library's purpose is to eliminate the need
to link targets directly to Vulkan, and load it dynamically instead at
runtime, using `dlopen` and `LoadLibrary`.

Remove the direct linking of the Vulkan library from targets that link
to `vulkan-wrapper`.

Signed-off-by: Ahmed Hesham <ahmed.hesham@arm.com>
@bashbaug
Copy link
Contributor

bashbaug commented Jul 9, 2024

Merging as discussed in the July 9th teleconference.

@bashbaug bashbaug merged commit 47546a5 into KhronosGroup:main Jul 9, 2024
7 checks passed
@ahesham-arm ahesham-arm deleted the vulkan-linking branch July 9, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulkan should be linked using the vulkan-wrapper and not directly
3 participants