Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

computeinfo: add CL_DEVICE_HALF_FP_CONFIG #2001

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

svenvh
Copy link
Member

@svenvh svenvh commented Jul 5, 2024

The computeinfo test already checks that the cl_khr_fp16 extension is available before querying CL_DEVICE_HALF_FP_CONFIG, but never actually made the CL_DEVICE_HALF_FP_CONFIG query.

kpet
kpet previously approved these changes Jul 9, 2024
Copy link
Contributor

@kpet kpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a potential suggestion for improvement.

test_conformance/computeinfo/main.cpp Outdated Show resolved Hide resolved
The computeinfo test already checks that the cl_khr_fp16 extension is
available before querying `CL_DEVICE_HALF_FP_CONFIG`, but never
actually made the `CL_DEVICE_HALF_FP_CONFIG` query.

Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
@bashbaug
Copy link
Contributor

Merging as discussed in the July 16th teleconference.

@bashbaug bashbaug merged commit 8558eb8 into KhronosGroup:main Jul 16, 2024
7 checks passed
@svenvh svenvh deleted the computeinfo-half-config branch July 17, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants