Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sccache on all CI platforms #2014

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

ahesham-arm
Copy link
Contributor

MSVC on Windows was previously omitted from the list of CI platforms that use sccache. Unify the CMAKE_CACHE_OPTIONS used for all CI platforms.

In the case of a 100% cache hit, this cuts down the average checks time from 8 minutes to 4 minutes, example:
https://github.com/ahesham-arm/OpenCL-CTS/actions/runs/9896449792

MSVC on Windows was previously omitted from the list of CI platforms
that use sccache. Unify the CMAKE_CACHE_OPTIONS used for all CI
platforms.

In the case of a 100% cache hit, this cuts down the average checks
time from 8 minutes to 4 minutes, example:
https://github.com/ahesham-arm/OpenCL-CTS/actions/runs/9896449792
Copy link
Contributor

@kpet kpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it seems to be passing the CI so I assume that whatever issue we might have faced in the past is now fixed. We can always revert the change if it's not the case.

@bashbaug
Copy link
Contributor

Merging as discussed in the July 16th teleconference.

@bashbaug bashbaug merged commit 070052c into KhronosGroup:main Jul 16, 2024
7 checks passed
@ahesham-arm ahesham-arm deleted the ci_msvc branch July 16, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants