Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[printf]: input value should be exactly representable as 32-bit float #2015

Merged
merged 1 commit into from
Jul 18, 2024
Merged

[printf]: input value should be exactly representable as 32-bit float #2015

merged 1 commit into from
Jul 18, 2024

Conversation

dneto0
Copy link
Contributor

@dneto0 dneto0 commented Jul 18, 2024

Fixed: #2009

@dneto0 dneto0 mentioned this pull request Jul 18, 2024
Closed
Kerilk
Kerilk approved these changes Jul 18, 2024
View reviewed changes
Copy link

@Kerilk Kerilk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with this Ruby program:

irb(main):001:0> require 'float-formats'
irb(main):002:0> puts Flt::IEEE_binary32(789456128.0).to(Float)
789456128.0
irb(main):003:0> puts Flt::IEEE_binary32(789456123.0).to(Float)
789456128.0

@bashbaug bashbaug merged commit 5b5e43e into KhronosGroup:main Jul 18, 2024
7 checks passed
@dneto0
Copy link
Contributor Author

dneto0 commented Jul 19, 2024

I use https://float.exposed It's super friendly

Example: https://float.exposed/0x4e3c3894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerilk Kerilk Kerilk approved these changes

@bashbaug bashbaug bashbaug approved these changes

Assignees
No one assigned
Labels
focused review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_printf producing false expected results
3 participants
@dneto0 @Kerilk @bashbaug