[printf] Test empty format string, and empty arg string #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know that Clvk+Clspv fail on these. |
svenvh
approved these changes
Jul 22, 2024
| @@ -714,6 +714,12 @@ testCase testCaseChar = { | |||
|
|
|||
| std::vector<printDataGenParameters> printStringGenParameters = { | |||
|
|
|||
| // empty format | |||
| { {""}, "\"foo\"" }, | |||
There was a problem hiding this comment.
This results in a printf call with an excess data argument (printf("\n","foo");), but that should be fine according to the spec:
If the format is exhausted while arguments remain, the excess arguments are evaluated (as always) but are otherwise ignored.
|
I don't have the ability to merge this PR. Please merge if you're happy with it. |
kpet
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1058