bruteforce: Fixes comparisons with zero and reference math #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lakshmih
commented
Jul 23, 2024
lakshmih
commented
- test is an unsigned short, convert using HTF before comparison with 0.0f
- OpenCL s7.5.3 sign of zero is undefined when FTZ happens so modify to cover +0 and -0
- use f_fma for reference math
- test is an unsigned short, convert using HTF before comparison with 0.0f - OpenCL s7.5.3 sign of zero is undefined when FTZ happens so modify to cover +0 and -0 - use f_fma for reference math
svenvh
reviewed
Jul 23, 2024
| overflow[j] = | ||
| FE_OVERFLOW == (FE_OVERFLOW & fetestexcept(FE_OVERFLOW)); | ||
| } | ||
| } | ||
| else | ||
| { | ||
| for (size_t j = 0; j < bufferElements; j++) | ||
| res[j] = HFD((double)f->dfunc.f_fff(HTF(hp0[j]), HTF(hp1[j]), |
There was a problem hiding this comment.
There is another call to dfunc.f_fff on line 280; should that also be changed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.