Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added printf test for double type cases #2022

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

shajder
Copy link
Contributor

@shajder shajder commented Jul 23, 2024

according to work plan for issue #1058

@svenvh svenvh self-requested a review July 23, 2024 21:04
Copy link
Member

@svenvh svenvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo some minor nits.

I don't have any fp64 devices for testing though, so this should ideally be reviewed by vendors supporting fp64.

test_conformance/printf/util_printf.cpp Outdated Show resolved Hide resolved
test_conformance/printf/util_printf.cpp Outdated Show resolved Hide resolved
test_conformance/printf/test_printf.cpp Outdated Show resolved Hide resolved
test_conformance/printf/test_printf.cpp Outdated Show resolved Hide resolved
bashbaug
bashbaug previously approved these changes Aug 20, 2024
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tested a couple of devices that support fp64 and most of them passed.

I did find a couple of failures with POCL, but these appears to be POCL issues and not test issues (maybe the double literal is interpreted as a float literal?):

14)testing printf("%-#20.15e",789456123.0)
verifyOutputBuffer failed with kernel: 
__kernel void test5(void)
{
   printf("%-#20.15e\n",789456123.0);
}

 expected: 7.894561230000000e+08
 got:      7.894561280000000e+08
15)testing printf("%+#21.15E",789456123.0)
verifyOutputBuffer failed with kernel: 
__kernel void test5(void)
{
   printf("%+#21.15E\n",789456123.0);
}

 expected: +7.894561230000000E+08
 got:      +7.894561280000000E+08

@bashbaug
Copy link
Contributor

Note, there is a merge conflict that needs to be resolved.

@shajder
Copy link
Contributor Author

shajder commented Aug 27, 2024

Note, there is a merge conflict that needs to be resolved.

Conflicts solved.

@bashbaug bashbaug merged commit 0a00a1f into KhronosGroup:main Aug 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants