Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to track wether glut has been initialized #2023

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

energystoryhhl
Copy link
Contributor

I found an issue about CTS running gl / CL-GL interop case issue, I found glutInit double called in CTS CLGL test case code, which will lead to an error:

        freeglut (./test_gl): illegal glutInit() reinitialization attempt

root cause is in: test_conformance/gl/main.cpp:343

        if (glEnv->Init(&argc, (char **)argv, CL_TRUE))

the glEnv->Init has already called in same file line:260, the function glutInit in glEnv->Init can not be called twice, then a error will occur although all the gl / CLGL cases are passed. Then in the full quick CTS running it will appear:

        (12-Jul 03:54:01)     BEGIN  OpenCL-GL Sharing                       : 
       PASSED sub-test.
       PASSED 23 of 23 tests.
       (12-Jul 04:01:48)     FAILED OpenCL-GL Sharing                       : (467s, test  34/53)

Although all the gl/CLGL cases are passed, but this group test is judged to failed.

This issue already been found in #1885
And fixed partly by: 02471c8

But I found in setup_osx.cpp, the glutInit still has double init issue, I add the same fix like previous fix,
can you please help to review?

@CLAassistant
Copy link

CLAassistant commented Jul 24, 2024

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Honglei Huang <Honglei1.Huang@amd.com>
@energystoryhhl
Copy link
Contributor Author

Hi @svenvh,

My name is Honglei Huang, working for AMD, and I am doing a OpenCL virtualization project.
I found this issue in my local test.

I am trying to merge this PR into main-line, but this need write access people to do that. What
process I need currently?

@svenvh
Copy link
Member

svenvh commented Sep 20, 2024

No objections/concerns were raised in the ~2 months that this PR was open; moreover it's applying a fix similar to a previously merged PR. Hence merging.

@svenvh svenvh merged commit 2d077cf into KhronosGroup:main Sep 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants