api: fix -Wformat warnings #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenvh
commented
Jul 24, 2024
| log_error("ERROR: Mem object " name \ | ||
| " did not validate! (expected " type ", got " type \ | ||
| " from %s:%d)\n", \ | ||
| (cast)expected, (cast)val, __FILE__, __LINE__); \ |
There was a problem hiding this comment.
The only change here besides the formatting is the (cast) in front of expected.
EwanC
previously approved these changes
Jul 24, 2024
EwanC
previously approved these changes
Jul 24, 2024
The main sources of warnings were: * Printing of a `size_t` which requires the `%zu` specifier. * Printing of `cl_long`/`cl_ulong` which is now done using the `PRI*64` macros to ensure portability across 32 and 64-bit builds. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
|
Rebased and fixed conflicts. |
EwanC
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main sources of warnings were:
Printing of a
size_twhich requires the%zuspecifier.Printing of
cl_long/cl_ulongwhich is now done using thePRI*64macros to ensure portability across 32 and 64-bit builds.