Added two tests not calling event calback upon error status #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashbaug
reviewed
Jul 31, 2024
lakshmih
previously approved these changes
Aug 12, 2024
bashbaug
previously approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Thanks, latest version LGTM!
Bikeshedding: The names of the new tests are currently "callback_not_called_simple" and "callback_not_called_enqueue_command", though this is a bit confusing because the tests are verifying that the callbacks are called, not that they are NOT called. Would it be better to call them something like "callback_on_error_simple" and "callback_on_error_enqueue_command"?
To be clear, I'm fine merging this as-is, and the test behavior looks good. Thanks!
kamil-goras-mobica
dismissed stale reviews from bashbaug and lakshmih
via
145580d
bashbaug
approved these changes
Aug 19, 2024
lakshmih
approved these changes
Aug 20, 2024
|
Merging as discussed in the August 20th teleconference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1900
Tested on POCL, callback is not called.