-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend testing of CL_UNORM_INT_101010_2 #2031
Conversation
All existing tests in `test_image_streams`, that are capable of testing image formats using the `CL_UNORM_INT_101010_2` data type, now do so.
1b56438
to
f5c9ec0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a search for CL_UNORM_INT_101010
, thinking that these are places that likely need to be updated for CL_UNORM_INT_101010_2
. Can you check that these don't need updates?
get_32_bit_image_format()
compare_scanlines()
- this one is probably OK.get_format_max_int()
get_format_min_int()
read_image_pixel()
get_pixel_bytes()
There are a few others in other test suites also, but maybe those are intended for another PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be surprised if there weren't a few more places that need updates for 101010_2, but I didn't find anymore cases that are obviously missing. Thanks!
Any objections to merging this PR ahead of the next teleconference? It is blocking the addition of testing for the 2_101010 format added by KhronosGroup/OpenCL-Docs#1223. |
I'm going to go ahead and merge this. Since these are purely additions I think the risk of problems for implementations that do not support the 101010_2 format is low. If we find problems we can always revert it. @lakshmih FYI. |
Thanks! |
All existing tests in
test_image_streams
, that are capable of testing image formats using theCL_UNORM_INT_101010_2
data type, now do so.