Fix bug in copy image mipmap comparisons #2032
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The destination image for mipmap copies is incorrect, use the width of the mip-level instead of mip-level 0. Deletes redundant scanline comparison.
joshqti
force-pushed
the
fix_copy_and_fill
branch
from
d1a6573
to
c24c601
Compare
bashbaug
reviewed
Aug 20, 2024
There was a problem hiding this comment.
This seems reasonable to me, but these tests are hard to follow.
Is there any test execution time difference after this change? I'd want to check that calling compare_scanlines unconditionally vs. only after calling memcmp doesn't slow down testing, since memcmp will be sufficient for most image formats, and it'll be a lot faster to compare the entire scanline in one call using memcpy vs. pixel-by-pixel as part of compare_scanlines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The destination image for mipmap copies is incorrect, use the width of the mip-level instead of mip-level 0. The check if (where < dstImageInfo->width) is not correct, width is the size of level 0, but it should be the width of the destination mip level.
Deletes redundant scanline comparison, which is confusing and uneccesary. compare_scanline and memcmp do the same thing, except compare_scanline correctly take image format into account, whereas memcmp finds all differences.