cl_fill_image: Use CL_DEVICE_VERSION instead of CL_DEVICE_NUMERIC_VER… #2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lakshmih
force-pushed
the
fill_images_version_check
branch
from
af7a3d2
to
d0f07ca
Compare
kpet
requested changes
Aug 9, 2024
lakshmih
force-pushed
the
fill_images_version_check
branch
from
d0f07ca
to
510fb34
Compare
kpet
reviewed
Aug 13, 2024
| @@ -117,7 +108,8 @@ cl_mem create_image( cl_context context, cl_command_queue queue, BufferOwningPtr | |||
| cl_mem_flags buffer_flags = CL_MEM_READ_WRITE; | |||
| if (gEnablePitch) | |||
| { | |||
| if (CL_VERSION_MAJOR(version) == 1) | |||
| int major = (version.to_int()) / 10; | |||
There was a problem hiding this comment.
We should probably add Version::major() and Version::minor() getters to the harness code so users don't have to do math.
lakshmih
force-pushed
the
fill_images_version_check
branch
from
510fb34
to
1d34089
Compare
CL_DEVICE_NUMERIC_VERSION is only available from OpenCL 3.0 Use CL_DEVICE_VERSION instead.
lakshmih
force-pushed
the
fill_images_version_check
branch
from
1d34089
to
abea311
Compare
bashbaug
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…SION
CL_DEVICE_NUMERIC_VERSION is only available from OpenCL 3.0 Use CL_DEVICE_VERSION instead.