Fix external semaphore test when exportability is not supported #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow get_device_semaphore_handle_types to return CL_SUCCESS for case where implementation returns '0' size for import/export handle type query to indicate that it doesn't support importing/exporting semaphore. * If cl_khr_external_semaphore is reported, add condition to check any of import/export or maybe both are supported. * Current test performs a union rather than intersection of import and export handle types list, perform an intersection to find common handle types.
An implementation may not support exportable semaphore, subtests available as part of cl_khr_external_semaphore assumes support for exportable semaphore, resulting in failure on such implementation. Instead of skipping these test, allow importable semaphore creation for the purpose of testing.
saurabhnv
force-pushed
the
external_semaphore
branch
from
417cd69
to
06f1b0d
Compare
lakshmih
approved these changes
Aug 27, 2024
bashbaug
approved these changes
Aug 28, 2024
Comment on lines
+104
to
+110
| std::vector<cl_external_semaphore_handle_type_khr> | ||
| handle_types_query_result(num_handle_types); | ||
| err = | ||
| clGetDeviceInfo(deviceID, param, | ||
| handle_types_query_result.size() | ||
| * sizeof(cl_external_semaphore_handle_type_khr), | ||
| handle_types_query_result.data(), nullptr); |
There was a problem hiding this comment.
Minor: could we read directly into the handle_types vector here, rather than reading into a temporary vector and then copying?
|
Merging as discussed in the September 3rd memory subgroup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation may not support exportable semaphore, subtests available in cl_khr_external_semaphore assumes support for exportable semaphore, resulting in failure on such implementation. Allow implementations to use importable semaphore in such cases.