Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test_event_dependencies.cpp #2049

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Update test_event_dependencies.cpp #2049

merged 1 commit into from
Sep 16, 2024

Conversation

aharon-abramson
Copy link
Contributor

In test_event_enqueue_wait_for_events_run_test:

  • Decrease TEST_COUNT to 10
  • Add clFinish to queues

@aharon-abramson
Update test_event_dependencies.cpp
4dc683e 
In test_event_enqueue_wait_for_events_run_test:
* Decrease TEST_COUNT to 10
* Add clFinish to queues
@aharon-abramson
Copy link
Contributor Author

Our implementation holds an internal reference count until a command (or one of its direct or indirect successors) is waited for and released (if the user holds a cl_event for it). When TEST_COUNT is 100, it means that our implementation must have at least 500 commands alive until a synchronization point for all of them is reached (which is currently also missing - therefore, I'm adding the calls for clFinish). I believe decreasing TEST_COUNT to 10 is enough for the test's purpose.

@aharon-abramson
Copy link
Contributor Author

@bashbaug, can you please merge it?

@bashbaug
Copy link
Contributor

Merging - has three approved reviews.

@bashbaug bashbaug merged commit a773a37 into KhronosGroup:main Sep 16, 2024
7 checks passed
@aharon-abramson aharon-abramson deleted the aharon-fix_errors_-in_test_event_enqueue_wait_for_events_run_test branch October 8, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashbaug bashbaug bashbaug approved these changes

@EwanC EwanC EwanC approved these changes

@lakshmih lakshmih lakshmih approved these changes

Assignees
No one assigned
Labels
focused review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aharon-abramson @bashbaug @lakshmih @EwanC