Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compile Vulkan SPIR-V shaders in CMAKE_CURRENT_BINARY_DIR #2055

Merged
merged 3 commits into from
Sep 16, 2024
Merged

compile Vulkan SPIR-V shaders in CMAKE_CURRENT_BINARY_DIR #2055

merged 3 commits into from
Sep 16, 2024

Conversation

bashbaug
Copy link
Contributor

fixes #2040

  • Compiles the Vulkan SPIR-V files in a directory based off of CMAKE_CURRENT_BINARY_DIR.
  • Changes the search path for the Vulkan SPIR-V files to this directory rather than a semi-arbitrary set of directories.

@bashbaug
Copy link
Contributor Author

Hmm, this is going to need a bit more work on Windows and other multi-config generators, since these executables get built into a directory based on the current configuration. Converting to a "draft" while I work this out.

@bashbaug bashbaug marked this pull request as draft August 19, 2024 23:03
@bashbaug
Copy link
Contributor Author

OK, I think I have a solution that works for the multi-config generators now.

@bashbaug bashbaug marked this pull request as ready for review August 19, 2024 23:50
kpet
kpet approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@kpet kpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A step in the right direction :).

nikhiljnv
nikhiljnv approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@nikhiljnv nikhiljnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kpet kpet merged commit a395174 into KhronosGroup:main Sep 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lakshmih lakshmih lakshmih approved these changes

@kpet kpet kpet approved these changes

@nikhiljnv nikhiljnv nikhiljnv approved these changes

Assignees
No one assigned
Labels
focused review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stop generating Vulkan SPV in source directories
4 participants
@bashbaug @lakshmih @kpet @nikhiljnv