Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] math_brute_force: remove warning options #2061

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

svenvh
Copy link
Member

@svenvh svenvh commented Aug 28, 2024

All of these are already set in the top-level CMakeLists.txt nowadays, so no need to repeat them in the test's own CMakeLists.txt.

All of these are set in the top-level `CMakeLists.txt` nowadays, so no
need to repeat them in the test's own `CMakeLists.txt`.

Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
@svenvh
Copy link
Member Author

svenvh commented Aug 29, 2024

Suspecting there was an update to the Windows runners that broke our Windows builds:

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.41.34120\include\cmath(831): error C2062: type 'signed char' unexpected

Previous runs with MSVC/14.40.33807 were passing.

Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I don't see anywhere we are setting -Wno-strict-aliasing anymore, but maybe that's no longer a problem?

@svenvh
Copy link
Member Author

svenvh commented Aug 29, 2024

I don't see anywhere we are setting -Wno-strict-aliasing anymore, but maybe that's no longer a problem?

Good catch, I should have said "... or no longer needed", as we don't need -Wno-strict-aliasing anymore.

@svenvh
Copy link
Member Author

svenvh commented Sep 6, 2024

Close/reopen to retrigger CI.

@svenvh svenvh closed this Sep 6, 2024
@svenvh svenvh reopened this Sep 6, 2024
@bashbaug
Copy link
Contributor

Two approvals and low risk. Merging.

@bashbaug bashbaug merged commit 97045f8 into KhronosGroup:main Sep 19, 2024
12 of 13 checks passed
@svenvh svenvh deleted the math-drop-compile-options branch September 19, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants