fix generic_address_space, command_buffer_event_sync, test_compiler and images/test_1D_buffer #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the allocated buffer for image1d_buffer_t was smaller than the requested image properties (width * pixel_size) would require.
according to specification, these can be executed asynchronously by the OpenCL runtime.
Skip the test if program scope variables are not supported.
|
The code check is complaining about the extension list, however i think the existing formatting is more readable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes several issues:
generic_address_spacetest: add check for program scope variables. The test uses both generic AS and program-scope variables, however it only checked the generic-AS presence inclGetDeviceInfo.compiler/test_compiler_defines_for_extensions.cpp: addcl_khr_command_buffer_multi_deviceto the list of recognized extensionscommand_buffer_event_sync.cpp: add delays for testingclSetEventCallback- according to specification, these can be executed asynchronously (in a separate thread) by the OpenCL implementation, hence the event callback is not quaranteed to be called beforeclFinish()returns. Existing testevents/test_callbacks.cppalso waits for callback with loops of usleep.images/kernel_image_methods/test_1D_buffer.cpp: fix allocation size being too small for the 1D buffer backing the image