Specify precision in the format flag for float4 hexadecimal output #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC outputs full precision representation with trailing zeros for "%a" specifier on Windows, which also conforms to OpenCL 3.0 specs. Signed-off-by: Cui, Dele <dele.cui@intel.com>
|
|
delecui
commented
Aug 30, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This will ensure consistent output on any conforming implementation. Note that the specification does not define the output style when precision is missing. Signed-off-by: Cui, Dele <dele.cui@intel.com>
delecui
changed the title
svenvh
approved these changes
Aug 30, 2024
bashbaug
approved these changes
Aug 30, 2024
|
Hi @svenvh, Could you help merge this PR? Thanks. I don't have permission to merge. |
We may want to leave this open for a few more days, so that other vendors have a chance to look at it. |
Understood. Thanks for the update. Will wait for further reviews. |
|
Close/reopen to retrigger CI. |
|
Hi @svenvh, Can we land this PR now ? Thanks. |
|
This has been open for almost 3 weeks now, and has 2 approvals, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure consistent output on any conforming implementation.
Note that the specification does not define the output style when
precision is missing.