conversions: fix condition for adding -cl-denorms-are-zero #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @svenvh , the fix recovers previous behavior, is it ready to land? Thanks. |
Not yet, this PR needs an approving review first. |
Commit b6941b6 ("Add fp16 testing to conversions and bruteforce (KhronosGroup#1975)", 2024-06-18) introduced a behavioural change for non-half tests. The `-cl-denorms-are-zero` option could be added for non-half tests such as `char_rtn_float` even when `gForceFTZ` was `false`. Fix the condition by also taking the input and output types into account. Signed-off-by: Sven van Haastregt <sven.vanhaastregt@arm.com>
svenvh
force-pushed
the
conversion-forceftz
branch
from
6026204
to
9d53a6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit b6941b6 ("Add fp16 testing to conversions and bruteforce (#1975)", 2024-06-18) introduced a behavioural change for non-half tests. The
-cl-denorms-are-zerooption could be added for non-half tests such aschar_rtn_floateven whengForceFTZwasfalse. Fix the condition by also taking the input and output types into account.