Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a few array-based mutable command buffer issues #2074

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix a few array-based mutable command buffer issues #2074

merged 1 commit into from
Sep 17, 2024

Conversation

bashbaug
Copy link
Contributor

@bashbaug bashbaug commented Sep 6, 2024 •
edited
Loading

fixes a few minor issues introduced by #1984.

edit: Tested with the updated command buffer emulation layer on a device that supports out-of-order queues and SVM and all of the test_cl_khr_mutable_dispatch tests pass.

@bashbaug bashbaug requested a review from EwanC September 6, 2024 20:23
EwanC
EwanC approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching these

@bashbaug bashbaug merged commit dd2117f into KhronosGroup:main Sep 17, 2024
7 checks passed
@bashbaug bashbaug deleted the mutable-command-buffer-fixes branch September 17, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwanC EwanC EwanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bashbaug @EwanC