Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vulkan: accept device selection #2113

Merged
merged 1 commit into from
Oct 22, 2024
Merged

vulkan: accept device selection #2113

merged 1 commit into from
Oct 22, 2024

Conversation

joshqti
Copy link
Contributor

@joshqti joshqti commented Oct 14, 2024

  • read CL_DEVICE_TYPE_ when specified like other conformance tests
  • reject non-GPU device types

@joshqti
vulkan: accept device selection
aacb5da 
- read CL_DEVICE_TYPE_ when specified like other conformance tests
- reject non-GPU device types
@nikhiljnv
Copy link
Contributor

nikhiljnv commented Oct 22, 2024 •
edited
Loading

Discussed in memory subgroup call of October 22nd. We should reuse test harness functionality.
Qualcomm will check if there is an issue or file one.

nikhiljnv
nikhiljnv approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@nikhiljnv nikhiljnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nikhiljnv
Copy link
Contributor

Merging as discussed in Memory subgroup call of October 22nd, 2024.

@nikhiljnv nikhiljnv merged commit 899cbf5 into KhronosGroup:main Oct 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhiljnv nikhiljnv nikhiljnv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshqti @nikhiljnv