Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vulkan: Choose where Shaders are generated #2114

Merged
merged 1 commit into from
Oct 15, 2024
Merged

vulkan: Choose where Shaders are generated #2114

merged 1 commit into from
Oct 15, 2024

Conversation

joshqti
Copy link
Contributor

@joshqti joshqti commented Oct 14, 2024

  • generate shader files in VULKAN_TEST_RESOURCES directory
  • allows for outside CMakeLists to specify arbitrary destination

@joshqti
vulkan: Choose where Shaders are generated
6f96f53 
- generate shader files in VULKAN_TEST_RESOURCES directory
- allows for outside CMakeLists to specify arbitrary destination
@joshqti joshqti requested a review from bashbaug October 14, 2024 21:25
bashbaug
bashbaug approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging as discussed in the October 15th memory subgroup.

Some additional changes may be needed to find the shader binaries in a different directory, but we will cross that bridge if we come to it.

@bashbaug bashbaug merged commit 115068e into KhronosGroup:main Oct 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashbaug bashbaug bashbaug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshqti @bashbaug