Updates to win32 named handle type changes.

Address review comments. Fixes #943
KhronosGroup · Jun 11, 2024 · 228a277 · 228a277
1 parent 3042bc1
commit 228a277
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 3 deletions.
diff --git a/api/cl_khr_external_memory_win32.asciidoc b/api/cl_khr_external_memory_win32.asciidoc
@@ -6,7 +6,7 @@ include::{generated}/meta/{refprefix}cl_khr_external_memory_win32.txt[]
 === Other Extension Metadata
 
 *Last Modified Date*::
- 2024-03-15
+ 2024-06-11
 *IP Status*::
  No known IP claims.
 *Contributors*::
@@ -58,3 +58,6 @@ image memory object.
  (provisional).
  * Revision 1.0.0, 2024-03-15
  ** First non-provisional version.
+ * Revision 1.1.0, 2024-06-11
+ ** Added {CL_EXTERNAL_MEMORY_HANDLE_OPAQUE_WIN32_NAME_KHR}.
+
diff --git a/api/cl_khr_external_semaphore_win32.asciidoc b/api/cl_khr_external_semaphore_win32.asciidoc
@@ -6,7 +6,7 @@ include::{generated}/meta/{refprefix}cl_khr_external_semaphore_win32.txt[]
 === Other Extension Metadata
 
 *Last Modified Date*::
- 2021-09-10
+ 2024-06-11
 *IP Status*::
  No known IP claims.
 *Contributors*::
@@ -44,3 +44,5 @@ introduced by {cl_khr_external_semaphore_EXT}.
 
  * Revision 0.9.0, 2021-09-10
  ** Initial version (provisional).
+ * Revision 0.9.1, 2024-06-11
+ ** Added {CL_SEMAPHORE_HANDLE_OPAQUE_WIN32_KMT_KHR}.
diff --git a/api/opencl_runtime_layer.asciidoc b/api/opencl_runtime_layer.asciidoc
@@ -5618,16 +5618,18 @@ buffer or an image memory object from an external handle:
  It does not own a reference to the underlying memory resource
  represented by its memory object, and will therefore become invalid when
  all memory objects associated with it are destroyed.
-endif::cl_khr_external_memory_win32[]
  * {CL_EXTERNAL_MEMORY_HANDLE_OPAQUE_WIN32_NAME_KHR_anchor} specifies an NT handle name that
  has only limited valid usage outside of OpenCL and other compatible
  APIs.
+ NT handle name is NULL or a null-terminated UTF-16 string naming the payload to import.
  It must be compatible with the functions `DuplicateHandle`,
  `CloseHandle`, `CompareObjectHandles`, `GetHandleInformation`, and
  `SetHandleInformation`.
  It owns a reference to the underlying memory resource represented by its
  memory object.
 
+endif::cl_khr_external_memory_win32[]
+
 For these extensions, importing memory object payloads from Windows handles
 does not transfer ownership of the handle to the OpenCL implementation.
 For handle types defined as NT handles, the application must release handle
@@ -13137,6 +13139,7 @@ a semaphore from an external handle:
  when all semaphore objects associated with it are destroyed.
  * {CL_SEMAPHORE_HANDLE_OPAQUE_WIN32_NAME_KHR} specifies an NT handle name that has
  only limited valid usage outside of OpenCL and other compatible APIs.
+ NT handle name is NULL or a null-terminated UTF-16 string naming the payload to import.
  It must be compatible with the functions `DuplicateHandle`,
  `CloseHandle`, `CompareObjectHandles`, `GetHandleInformation`, and
  `SetHandleInformation`.

diff --git a/xml/cl.xml b/xml/cl.xml
@@ -7085,6 +7085,7 @@ server's OpenCL/api-docs repository.
  <require comment="cl_external_semaphore_handle_type_khr">
  <enum name="CL_SEMAPHORE_HANDLE_OPAQUE_WIN32_KHR"/>
  <enum name="CL_SEMAPHORE_HANDLE_OPAQUE_WIN32_KMT_KHR"/>
+ <enum name="CL_SEMAPHORE_HANDLE_OPAQUE_WIN32_NAME_KHR"/>
  </require>
  </extension>
  <extension name="cl_khr_external_memory" revision="0.9.3" supported="opencl" depends="CL_VERSION_3_0" ratified="opencl">
@@ -7137,6 +7138,7 @@ server's OpenCL/api-docs repository.
  <require comment="cl_external_memory_handle_type_khr">
  <enum name="CL_EXTERNAL_MEMORY_HANDLE_OPAQUE_WIN32_KHR"/>
  <enum name="CL_EXTERNAL_MEMORY_HANDLE_OPAQUE_WIN32_KMT_KHR"/>
+ <enum name="CL_EXTERNAL_MEMORY_HANDLE_OPAQUE_WIN32_NAME_KHR"/>
  </require>
  </extension>
  <extension name="cl_intel_sharing_format_query" supported="opencl">