Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing asciidoctor attribute value for the name of an extension? #1101

Closed
bashbaug opened this issue Mar 25, 2024 · 2 comments · Fixed by #1112
Closed

missing asciidoctor attribute value for the name of an extension? #1101

bashbaug opened this issue Mar 25, 2024 · 2 comments · Fixed by #1112

Comments

@bashbaug
Copy link
Contributor

There is one place in the OpenCL C spec that uses an extension name as an asciidoctor attribute (cl_khr_integer_dot_product):

ifdef::cl_khr_integer_dot_product[]
| {opencl_c_integer_dot_product_input_4x8bit_packed} +
  (when the {cl_khr_integer_dot_product} extension macro is defined)
| The OpenCL C compiler supports built-in functions that perform dot
products on 4x8 bit packed integer vectors.

This attribute is defined to get into this code section, but it is not currently defined to be anything, so in the rendered specification it looks like "(when the extension macro is defined)". I don't think this is the expected behavior.

Should we define a value for this asciidoctor attribute? Or should we just write the name of the extension manually?

@bashbaug
Copy link
Contributor Author

Looking at this a bit more, I think this possibly should be the extension link <<cl_khr_integer_dot_product>> instead?

There are a few other places in the spec where we use similar text, for example:

The functionality described in the following table requires support for the cl_khr_subgroups extension macro; or for OpenCL 3.0 or newer and the __opencl_c_subgroups feature.

@oddhack
Copy link
Contributor

oddhack commented Mar 28, 2024

Should be fixed in #1112. I think this was one of the first extensions I incorporated and my process improved over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants