Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markup for a few extension names. #1112

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Fix markup for a few extension names. #1112

merged 1 commit into from
Mar 31, 2024

Conversation

oddhack
Copy link
Contributor

@oddhack oddhack commented Mar 28, 2024

Closes #1101

@oddhack
Copy link
Contributor Author

oddhack commented Mar 28, 2024

@outofcontrol I'm seeing 'license/cla Expected - Waiting for status to be reported' still, about 90 minutes after the PR was submitted. Maybe the CLA bot needs to be kicked again? It seems OK on my other PR #1113 I submitted a few minutes later.

@outofcontrol
Copy link

@oddhack Does this go away once the review is done? We have been seen this message from cla-assistant for a couple of weeks now. Not entirely clear on where the issue lies. Wondering if perhaps this is a new message that shows when the PR has not met all the other requirements.

@oddhack
Copy link
Contributor Author

oddhack commented Mar 28, 2024

@oddhack Does this go away once the review is done? We have been seen this message from cla-assistant for a couple of weeks now. Not entirely clear on where the issue lies. Wondering if perhaps this is a new message that shows when the PR has not met all the other requirements.

Compare to #1113 - it also has requested reviews that have not been completed, but has cleared the CLA step. So that particular relationship does not seem to be the problem. Reviews are a separate block from 'checks' AFAICT - you can pass all the checks and still be blocked from merging because nobody has reviewed.

@bashbaug
Copy link
Contributor

I'm going to go ahead and merge this even though the CLA bot hasn't come back, since it's obviously OK in this case, but we really should figure out what's going on with it.

@bashbaug bashbaug merged commit 1bf9208 into main Mar 31, 2024
2 checks passed
@bashbaug bashbaug deleted the 1101-markup branch March 31, 2024 18:15
@oddhack
Copy link
Contributor Author

oddhack commented Apr 1, 2024

I'm going to go ahead and merge this even though the CLA bot hasn't come back, since it's obviously OK in this case, but we really should figure out what's going on with it.

@outofcontrol it feels like the CLAbot is forgetting about the PR somehow - did not clear the condition after 4 days. Unfortunately one of those difficult to reproduce situations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing asciidoctor attribute value for the name of an extension?
3 participants