Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension of cl_khr_icd to 2.0.0 with loader managed dispatch. #1005

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Kerilk
Copy link
Contributor

@Kerilk Kerilk commented Nov 22, 2023

This is a formal description of the proposal discussed here:
#1003

ext/cl_khr_icd.asciidoc Outdated Show resolved Hide resolved
ext/cl_khr_icd.asciidoc Outdated Show resolved Hide resolved
ext/cl_khr_icd.asciidoc Outdated Show resolved Hide resolved
ext/cl_khr_icd.asciidoc Outdated Show resolved Hide resolved
xml/cl.xml Show resolved Hide resolved
@Kerilk
Copy link
Contributor Author

Kerilk commented Sep 12, 2024

@keryell was concerned clPlatformID pointer for a non ICD 2.0.0 compatible could have the same value as the tag.

One way to avoid this problem would be to have a second entry in the dispatch table set to the tag value (clUnloadCompiler comes to mind) and check that both of these have the tag while loading the library. If the tag were not present in both, the implementation would not be loaded.

@keryell
Copy link
Member

keryell commented Sep 12, 2024

@keryell was concerned clPlatformID pointer for a non ICD 2.0.0 compatible could have the same value as the tag.

One way to avoid this problem would be to have a second entry in the dispatch table set to the tag value (clUnloadCompiler comes to mind) and check that both of these have the tag while loading the library. If the tag were not present in both, the implementation would not be loaded.

Thanks. This is quite simpler and more portable than the solution I was thinking to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants