Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup cl_khr_command_buffer after extension spec unification #1089

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

EwanC
Copy link
Contributor

@EwanC EwanC commented Mar 25, 2024

After PR #950 merged the cl_khr_command_buffer spec needs updated in a couple of places:

  • Error around num_queues to clCreateCommandBufferKHR should be in terms of cl_khr_command_buffer_multi_device.
  • "New Structure" heading can be deleted as these are listed under "New Types"
  • Typos in rendering of some types

@EwanC EwanC changed the title Fixup cl_khr_command_buffer after spec unification Fixup cl_khr_command_buffer after extension spec unification Mar 25, 2024
@EwanC EwanC added the cl_khr_command_buffer Relating to the command-buffer family of extension label Mar 25, 2024
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging as discussed in the March 26th teleconference.

@bashbaug
Copy link
Contributor

@KhronosWebservices the CLA bot seems to be stuck here too, can you help?

@KhronosWebservices
Copy link

@KhronosWebservices the CLA bot seems to be stuck here too, can you help?

Looking more closely at this now.

After PR KhronosGroup#950 merged the cl_khr_command_buffer spec needs
updated in a couple of places:

* Error around _num_queues_ to `clCreateCommandBufferKHR` should
  be in terms of `cl_khr_command_buffer_multi_device`.
* "New Structure" heading can be deleted as these are listed under
  "New Types"
* Typos in rendering of some types
@outofcontrol
Copy link

@bashbaug Did the cla-assistant resolve on its own? From what I can tell this is a problem at the cla-assistant end, as our tokens appeared to still be usable and lots of calls left.

@EwanC
Copy link
Contributor Author

EwanC commented Mar 26, 2024

@bashbaug Did the cla-assistant resolve on its own? From what I can tell this is a problem at the cla-assistant end, as our tokens appeared to still be usable and lots of calls left.

There was a merge conflict after another PR merged first, I pushed a rebase to resolve it and when the CI re-ran the issue disappeared

@bashbaug bashbaug merged commit 00c7969 into KhronosGroup:main Mar 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cl_khr_command_buffer Relating to the command-buffer family of extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants