Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify CL_DEVICE_TYPE_DEFAULT and CL_DEVICE_TYPE_ALL for custom devices #1117

Merged
merged 1 commit into from
Jul 9, 2024
Merged

clarify CL_DEVICE_TYPE_DEFAULT and CL_DEVICE_TYPE_ALL for custom devices #1117

merged 1 commit into from
Jul 9, 2024

Conversation

bashbaug
Copy link
Contributor

fixes #300

Fixes CL_DEVICE_TYPE_ALL - now it will return all devices in the platform, including custom devices.

Clarifies that CL_DEVICE_TYPE_DEFAULT may return a custom device if it is the only device in the platform.

@bashbaug bashbaug requested a review from kpet March 31, 2024 18:29
@oddhack oddhack mentioned this pull request Apr 1, 2024
Open
@bashbaug bashbaug added the needs-cts-coverage The CTS needs to be extended label Jul 9, 2024
@bashbaug
Copy link
Contributor Author

bashbaug commented Jul 9, 2024

Merging as discussed in the July 9th teleconference.

@bashbaug bashbaug merged commit 92c3de3 into KhronosGroup:main Jul 9, 2024
2 checks passed
@bashbaug bashbaug deleted the custom-device-updates branch July 9, 2024 16:46
@kpet kpet mentioned this pull request Jul 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpet kpet kpet approved these changes

@aharon-abramson aharon-abramson aharon-abramson approved these changes

Assignees
No one assigned
Labels
needs-cts-coverage The CTS needs to be extended
Projects
OpenCL specification maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CL_DEVICE_TYPE_ALL and custom devices
3 participants
@bashbaug @kpet @aharon-abramson