Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update non-provisional extensions to version 1.0.0 #1133

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

bashbaug
Copy link
Contributor

@bashbaug bashbaug commented Apr 3, 2024

Updates extensions that have been finalized to version 1.0.0.

@bashbaug
Copy link
Contributor Author

bashbaug commented Apr 3, 2024

@oddhack, there are a few extension specs with a comment block like this one:

//@ *Revision*::
//@     1.0.0
//@ *Extension and Version Dependencies*::
//@     This extension requires OpenCL 3.0.

Is this used for anything, or can it be removed?

@bashbaug bashbaug requested a review from alycm April 3, 2024 01:44
@oddhack
Copy link
Contributor

oddhack commented Apr 3, 2024

@oddhack, there are a few extension specs with a comment block like this one:

//@ *Revision*::
//@     1.0.0
//@ *Extension and Version Dependencies*::
//@     This extension requires OpenCL 3.0.

Is this used for anything, or can it be removed?

Those are just left over from the conversion process and can safely be removed. The dependencies are being generated from the XML now.

Copy link
Contributor

@alycm alycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alycm
Copy link
Contributor

alycm commented Apr 3, 2024

CLA bot hasn't run, already documented in #1128, there are no CLA issues with this PR, merging.

@alycm alycm merged commit da1282c into KhronosGroup:main Apr 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants