Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy up cl_khr_create_command_queue #1138

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 3 additions & 15 deletions api/cl_khr_create_command_queue.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -26,21 +26,11 @@ No new command-queue properties are required by this extension.
Applications may use the existing {CL_DEVICE_QUEUE_PROPERTIES} query to
determine command-queue properties that are supported by the device.

OpenCL 2.x devices may support this extension for compatibility.
Newer OpenCL devices may support this extension for compatibility.
In this scenario, the function added by this extension will have the same
capabilities as the core {clCreateCommandQueueWithProperties} API.
Applications that only target OpenCL 2.x devices should use the core OpenCL
2.x {clCreateCommandQueueWithProperties} API instead of this extension API.

NOTE: The type of the property value passed as {CL_QUEUE_PROPERTIES} to
{clCreateCommandQueueWithPropertiesKHR} is specified as
{cl_bitfield_TYPE} while the type passed to
{clCreateCommandQueueWithProperties} is
{cl_command_queue_properties_TYPE}.
While this is not a promotion in terms of the suffixing, both types
are aliased to {cl_ulong_TYPE}, so no ABI or compiler issues should
result if the extension and core APIs are supported.

Applications that only target newer OpenCL devices should use the core
{clCreateCommandQueueWithProperties} API instead of this extension API.

=== New Commands

Expand All @@ -50,8 +40,6 @@ result if the extension and core APIs are supported.

* {cl_queue_properties_khr_TYPE}

//@ TODO Missing bitfield values allowed for CL_QUEUE_PROPERTIES?

=== Version History

* Revision 1.0.0, 2020-04-21
Expand Down
4 changes: 0 additions & 4 deletions api/opencl_runtime_layer.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,6 @@ endif::cl_khr_create_command_queue[]

include::{generated}/api/version-notes/CL_QUEUE_PROPERTIES.asciidoc[]
| {cl_command_queue_properties_TYPE}

ifdef::cl_khr_create_command_queue[]
or {cl_bitfield_TYPE} if the {cl_khr_create_command_queue_EXT} extension is supported
endif::cl_khr_create_command_queue[]
| This is a bitfield and can be set to a combination of the following
values:

Expand Down