Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define extension macros in environment specification #1163

Merged
merged 1 commit into from
May 14, 2024

Conversation

kpet
Copy link
Contributor

@kpet kpet commented May 10, 2024

This was missed during the spec unification work.

Change-Id: I23107b104431abdac2eaf8a3b1ebedd10303fc12

This was missed during the spec unification work.

Signed-off-by: Kevin Petit <kevin.petit@arm.com>
Change-Id: I23107b104431abdac2eaf8a3b1ebedd10303fc12
@kpet kpet requested a review from bashbaug May 10, 2024 15:39
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is fine, but out of curiosity: is there anything that is currently broken by not including this file in the OpenCL SPIR-V environment specification?

@kpet
Copy link
Contributor Author

kpet commented May 10, 2024

Not that I know of. I found it was missing as part of drafting a new extension.

@bashbaug bashbaug merged commit b041b2f into KhronosGroup:main May 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants