Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to commands in API specification #1179

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

kpet
Copy link
Contributor

@kpet kpet commented Jun 4, 2024

Links were not created for commands defined by extensions. With this changes all uses of e.g. {clCreateSemaphoreWithPropertiesKHR} link to the definition of the command which makes navigating the specification much easier.

Change-Id: I4a9458609f4ba3229b66e3d169a68cb4564e2538

Links were not created for commands defined by extensions. With this
changes all uses of e.g. {clCreateSemaphoreWithPropertiesKHR} link
to the definition of the command which makes navigating the specification
much easier.

Signed-off-by: Kevin Petit <kevin.petit@arm.com>
Change-Id: I4a9458609f4ba3229b66e3d169a68cb4564e2538
@kpet kpet requested a review from bashbaug June 4, 2024 18:13
@bashbaug bashbaug linked an issue Jun 4, 2024 that may be closed by this pull request
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same fix as #1173, which is good. Ideally we would avoid duplicating work, though!

I'll just merge this one and I'll close my PR. Your comments are better, I think 😄

@bashbaug bashbaug merged commit f37a868 into KhronosGroup:main Jun 4, 2024
2 checks passed
@kpet kpet deleted the fix-command-links branch June 4, 2024 18:54
@kpet
Copy link
Contributor Author

kpet commented Jun 4, 2024

I hadn't seen that one fly by, sorry. I noticed the issue in today's teleconference and fixed it in the background. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extension API functions are still not links
2 participants