Publish the cl_img_swap_ops extension specification. #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashbaug
approved these changes
Jul 10, 2024
| |==== | ||
| | Function | Description | ||
| | gentype *img_swap_x*(gentype value) | ||
| a| `img_swap_x` swaps `values` between work-items in the following way: all work-items are divided into blocks of four consecutive elements. For each block: |
There was a problem hiding this comment.
Consider documenting the behavior if the number of work-items is not evenly divisible by four, or if some work-items in the block of four are inactive (due to flow control).
Also consider documenting what "consecutive" means, especially for multi-dimensional work-groups.
There was a problem hiding this comment.
I defined the behavior as undefined for these cases as I don't see any reasonable way of handling them.
Listing the initial extension version. Co-authored-by: Ben Ashbaugh <ben.ashbaugh@intel.com>
Defining behavior as undefined for cases when the number of work-items is not evenly divisible by four and if some work-items in the block of four are inactive, defining 1-dimensional local ID as a base for grouping work-items.
|
PR has been open for over a month with no additional comments. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publish the cl_img_swap_ops extension specification.