Fail spec creation if asciidoctor errors are encountered #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI is failing, as expected, because the spec source in |
This would have enabled the CI to catch a markup issue introduced by KhronosGroup#938. Signed-off-by: Kevin Petit <kevin.petit@arm.com> Change-Id: I49de3eaf623117f7c29d1019dedf5b342766a029
kpet
force-pushed
the
fail-ci-on-asciidoctor-error
branch
from
ae6d0b0
to
d827bba
Compare
|
It's still failing after a rebase. I'm looking into the failures. |
Change-Id: I0f9cbeddb72e0d76ba508b336d91c4ee640d77ad
|
Now passing with fixes to a few tables. The errors weren't flagged by my local version of asciidoctor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would have enabled the CI to catch a markup issue introduced by #938.
Change-Id: I49de3eaf623117f7c29d1019dedf5b342766a029