Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what re-import properties are accepted by clReImportSemaphoreSyncFdKHR #1219

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

kpet
Copy link
Contributor

@kpet kpet commented Aug 6, 2024

Align the language to clCreateBufferWithProperties.

@kpet kpet changed the title Return CL_INVALID_VALUE from clReImportSemaphoreSyncFdKHR when reimpo… Return CL_INVALID_VALUE from clReImportSemaphoreSyncFdKHR when reimport properties are not NULL Aug 6, 2024
…SyncFdKHR

Align the language to clCreateBufferWithProperties.

Signed-off-by: Kevin Petit <kevin.petit@arm.com>
Change-Id: I58659fc9cd7fd3ae5178826285fd84d6932b29d8
@kpet kpet changed the title Return CL_INVALID_VALUE from clReImportSemaphoreSyncFdKHR when reimport properties are not NULL Clarify what re-import properties are accepted by clReImportSemaphoreSyncFdKHR Aug 6, 2024
Copy link
Contributor

@nikhiljnv nikhiljnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nikhiljnv nikhiljnv merged commit b32ac1b into KhronosGroup:main Aug 13, 2024
2 checks passed
@nikhiljnv
Copy link
Contributor

Merging as discussed in memory subgroup call on August 13th 2024.

@kpet kpet deleted the reimport-error branch August 14, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants