Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate an OpenCL C built-in functions dictionary #1228

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

bashbaug
Copy link
Contributor

Possible fix for #1214

This PR generalizes the script used to generate OpenCL C feature dictionaries from #1212 so it can be used for other types of dictionaries also.

Then:

  1. It adds a list of OpenCL C built-in functions and uses the script to generate a dictionary for them.
  2. Replaces the built-in functions with hard-coded unicode zero-width spaces with the asciidoctor attributes instead.

I believe this fixes the issue.

A few additional notes:

  • I've only added the built-in functions with the hard-coded zero-width spaces. If desired, we could add additional built-in functions, also.
  • I haven't included any formatting in the generated built-in functions dictionary because some functions use bold formatting and other functions use monospace formatting. We ought to unify this at some point.

I've tried copy-pasting the function names from the HTML spec with both Chrome and FireFox and they both seem to work fine. I'm able to copy-paste the function names from the PDF spec, also.

@bashbaug
Copy link
Contributor Author

I found a few formatting issues I need to fix. Converting to draft.

@bashbaug bashbaug marked this pull request as draft August 27, 2024 16:17
@bashbaug
Copy link
Contributor Author

The formatting issue is fixed, so this is now ready to go.

@bashbaug bashbaug marked this pull request as ready for review August 29, 2024 17:59
@bashbaug bashbaug linked an issue Aug 30, 2024 that may be closed by this pull request
scripts/gen_dictionary_from_file.py Outdated Show resolved Hide resolved
@bashbaug bashbaug merged commit 528a370 into KhronosGroup:main Sep 10, 2024
2 checks passed
@bashbaug bashbaug deleted the generate-func-dictionary branch September 10, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Zero-width spaces in spec html
2 participants