clarify cl_mem_flags to not affect copies #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpet
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
I note that the information is presented as a note for all command buffer commands but not for enqueue commands (which is in line with the existing spec text for enqueue commands). Fine with the change as is but I'm wondering whether we want to align them all.
|
Merging as discussed in the October 29th teleconference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #770
Clarifies that the cl_mem_flags for the source and destination memory objects for copies are ignored, for both commands enqueued into a command-queue and commands recorded into a command-buffer.