Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document valid coordinate types when reading from or writing to images #1242

Merged
merged 1 commit into from
Oct 15, 2024
Merged

document valid coordinate types when reading from or writing to images #1242

merged 1 commit into from
Oct 15, 2024

Conversation

bashbaug
Copy link
Contributor

@bashbaug bashbaug commented Aug 29, 2024 •
edited
Loading

Fixes #841

Documents the valid coordinate types when reading from or writing to images.

This should match what is supported by OpenCL C and what is generated by Clang and the SPIR-V LLVM Translator for OpenCL C kernels today.

alycm
alycm approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@alycm alycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorially LGTM and the changes logically make sense. The primary action in #841 is to use 4-element vectors and that is reflected here.

@bashbaug bashbaug merged commit fac5fa8 into KhronosGroup:main Oct 15, 2024
2 checks passed
@bashbaug bashbaug deleted the coord-count-image-writes branch October 15, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alycm alycm alycm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 component coords for 3D image writes
2 participants
@bashbaug @alycm