Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify how to properly use and modify shared OpenCL objects #1243

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

bashbaug
Copy link
Contributor

Fixes #1114

Rephrases and simplifies the requirements to properly use and modify shared OpenCL objects.

Refers to the chapter describing the OpenCL memory consistency model vs. duplicating information.

Refer to the OpenCL memory consistency model vs. duplicating requirements.
@aharon-abramson
Copy link
Contributor

Does this appendix now give any new information? Maybe we should remove it altogether.

@alycm
Copy link
Contributor

alycm commented Oct 15, 2024

Does this appendix now give any new information? Maybe we should remove it altogether.

Like the other sections in this appendix I think the remaining text in this section is still informative. Though it is just referring to behaviour described more completely in the main spec.

This and the other two sections highlight consequences of this specification (and the C specification) that are relevant to both implementors and users.

Copy link
Contributor

@alycm alycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bashbaug bashbaug merged commit f912fe0 into KhronosGroup:main Oct 15, 2024
2 checks passed
@bashbaug bashbaug deleted the cleanup-shared-opencl-objects branch October 15, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sharing resources between command_queues requires event objects
3 participants