Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error when memory objects or semaphores are created with more than one external handle #1249

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Add error when memory objects or semaphores are created with more than one external handle #1249

merged 1 commit into from
Sep 24, 2024
+21 −4

Conversation

kpet
Copy link
Contributor

@kpet kpet commented Sep 3, 2024

Also link the description of external semaphore handles to the spec for clCreateSemaphoreWithPropertiesKHR.

Fixes #1246

Change-Id: Ifb4c02795c6d4db8aee9b5f14b10fecd26992fd5

bashbaug
bashbaug approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

I'd be comfortable calling this a patch revision to version 1.0.0 since there was no previously defined behavior for this scenario (and no CTS test for it, also), but if folks prefer a minor revision update I'm fine with that too.

@bashbaug
Copy link
Contributor

bashbaug commented Sep 9, 2024

Noting for completeness: #1256 updated error behavior and we're currently calling it a "patch" revision. I think this is making a similar update? If so, we should either call this a "patch" revision also, or change #1256 to be a "minor" revision update.

@kpet
Add error when memory objects or semaphores are created with more tha…
54f65bc 
…n one external handle

Also link the description of external semaphore handles to the spec
for clCreateSemaphoreWithPropertiesKHR.

Fixes #1246

Signed-off-by: Kevin Petit <kevin.petit@arm.com>
Change-Id: Ifb4c02795c6d4db8aee9b5f14b10fecd26992fd5
@bashbaug bashbaug merged commit af98a34 into main Sep 24, 2024
3 checks passed
@bashbaug bashbaug deleted the issue-1246 branch September 24, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lakshmih lakshmih lakshmih approved these changes

@bashbaug bashbaug bashbaug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Behaviour of clCreate{Buffer,Image}WithProperties when passing multiple external memory handles
3 participants
@kpet @bashbaug @lakshmih