add conversions for halfs to and from normalized image channel orders #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alycm
approved these changes
Jun 29, 2020
|
Thanks for the review comments! I'm fixing these now. |
bashbaug
force-pushed
the
193-image-half-conversions
branch
from
b8ce14b
to
2235d92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #193
This PR adds two sections to the
cl_khr_fp16spec that describe how half values are converted to normalized image channel orders (for image writes) and converted from normalized image channel orders (for image reads). These sections should match similar sections that are already in the OpenCL SPIR-V environment spec.