Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional enum names within already allocated block #772

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Add additional enum names within already allocated block #772

merged 1 commit into from
Mar 14, 2022

Conversation

mkinsner
Copy link

No description provided.

alycm
alycm approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@alycm alycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging immediately.

@alycm alycm merged commit 3f1f3e2 into KhronosGroup:main Mar 14, 2022
@bashbaug
Copy link
Contributor

It's fine to have merged this as-is, but I do think these enums are now going to be considered "orphaned": #730

@mkinsner
Copy link
Author

It's fine to have merged this as-is, but I do think these enums are now going to be considered "orphaned": #730

Agreed. I'll add an extension block with another PR shortly to fix that.

@alycm
Copy link
Contributor

alycm commented Mar 14, 2022

It's fine to have merged this as-is, but I do think these enums are now going to be considered "orphaned": #730

That's a good point! Hopefully we can get that script into the pre-merge checks in the coming months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alycm alycm alycm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkinsner @bashbaug @alycm