New Command-buffer query for supported queue properties #850
+25
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
added
the
OpenCL Extension Spec
bashbaug
reviewed
Oct 25, 2022
EwanC
force-pushed
the
command-buffer_supported_queue_props
branch
from
3a44a7b
to
74655d9
Compare
|
I lost track of this one, my apologies. Is it ready to go? |
No worries, I've deliberately been holding back from adding it to the WG agenda because of the Mobica CTS project adding command-buffer tests. I think doing an API change in the middle of that work is a complication we should avoid. So once that's done, I think we could make this API change and I can make the according CTS update myself to reflect it. |
EwanC
added a commit
to EwanC/OpenCL-Docs
that referenced
this pull request
Mar 31, 2023
Introduce query `CL_COMMAND_BUFFER_CONTEXT_KHR` for the `cl_context` associated with a command-buffer. This PR uses enum value `0x1299` which is also attempting be used by another command-buffer PR KhronosGroup#850 However, that PR still needs review so would prefer to use that enum here as `0x1299` is contiguous with the other command-buffer query enums, and I can find a new value for PR KhronosGroup#850 Closes KhronosGroup#898
EwanC
added a commit
to EwanC/OpenCL-Docs
that referenced
this pull request
Mar 31, 2023
Introduce query `CL_COMMAND_BUFFER_CONTEXT_KHR` for the `cl_context` associated with a command-buffer. This PR uses enum value `0x1299` which is also attempting be used by another command-buffer PR KhronosGroup#850 However, that PR still needs review so would prefer to use that enum here as `0x1299` is contiguous with the other command-buffer query enums, and I can find a new value for PR KhronosGroup#850 Closes KhronosGroup#898
EwanC
commented
Mar 31, 2023
bashbaug
pushed a commit
that referenced
this pull request
Apr 4, 2023
Introduce query `CL_COMMAND_BUFFER_CONTEXT_KHR` for the `cl_context` associated with a command-buffer. This PR uses enum value `0x1299` which is also attempting be used by another command-buffer PR #850 However, that PR still needs review so would prefer to use that enum here as `0x1299` is contiguous with the other command-buffer query enums, and I can find a new value for PR #850 Closes #898
aharon-abramson
approved these changes
Apr 4, 2023
EwanC
force-pushed
the
command-buffer_supported_queue_props
branch
from
74655d9
to
bcd5836
Compare
EwanC
added
the
cl_khr_command_buffer
EwanC
force-pushed
the
command-buffer_supported_queue_props
branch
from
bcd5836
to
6b5aae7
Compare
bcalidas
reviewed
May 24, 2023
ext/cl_khr_command_buffer.asciidoc
Outdated
| | Bitmask of the supported properties with which a command-queue may be created | ||
| to allow a command-buffer to be executed on it. It is invalid for a | ||
| command-queue to be created with a property not reported and still be | ||
| compatible with command-buffer execution. |
There was a problem hiding this comment.
Are the queue properties for executing a command buffer mandated to be the same as the queue properties while recording the command buffer.
There was a problem hiding this comment.
Yes we currently have this wording in the spec about being compatible
Command-buffers are created using an ordered list of command-queues that commands are recorded to and execute on by default. These command-queues can be replaced on command-buffer enqueue with different command-queues, provided for each element in the replacement list the substitute command-queue is compatible with the command-queue used on command-buffer creation. Where a compatible command-queue is defined as a command-queue with identical properties targeting the same device and in the same OpenCL context.
And then the actual error condition to clEnqueueCommandBufferKHR is
CL_INCOMPATIBLE_COMMAND_QUEUE_KHR if any element of queues is not compatible with the command-queue set on command_buffer creation at the same list index.
I've ignored that clSetCommandQueueProperty exists because its been depreciated since OpenCL 1.1, as that could change a command-queue's properties after creation. Maybe I should put a note about not using that.
EwanC
force-pushed
the
command-buffer_supported_queue_props
branch
2 times, most recently
from
fc422e1
to
731342c
Compare
This change introduces a new device query related to the command-buffer extension - `CL_DEVICE_COMMAND_BUFFER_SUPPORTED_QUEUE_PROPERTIES_KHR`. This is different from `CL_DEVICE_COMMAND_BUFFER_REQUIRED_QUEUE_PROPERTIES_KHR`, as we want to convey to the user that an implementation supports using a queue property with a command-buffer, but is not *required* to use the property. This supersedes reporting queue related values from the `CL_DEVICE_COMMAND_BUFFER_CAPABILITIES_KHR` query. The flaw with `CL_DEVICE_COMMAND_BUFFER_CAPABILITIES_KHR` is that it contains bits explicitly added by the command-buffer extension for reporting support for queue properties. This is a brittle design, as any new queue property added in future would need to have a new bit added here in the command-buffer extension to report support when used with command-buffers. Instead a better design is to have a new query reporting queue properties supported, `CL_DEVICE_COMMAND_BUFFER_SUPPORTED_QUEUE_PROPERTIES_KHR`, and keeping `CL_DEVICE_COMMAND_BUFFER_CAPABILITIES_KHR` for capabilities unrelated to the command-queue properties. The `CL_COMMAND_BUFFER_CAPABILITY_OUT_OF_ORDER_KHR` use-case can now be covered by returning `CL_QUEUE_OUT_OF_ORDER_EXEC_MODE_ENABLE` from `CL_DEVICE_COMMAND_BUFFER_SUPPORTED_QUEUE_PROPERTIES_KHR`, so it is removed.
EwanC
force-pushed
the
command-buffer_supported_queue_props
branch
from
731342c
to
6fa65be
Compare
EwanC
added a commit
to EwanC/OpenCL-Headers
that referenced
this pull request
Oct 2, 2024
Header update generated from OpenCL-Docs PR XML change KhronosGroup/OpenCL-Docs#850
EwanC
added a commit
to EwanC/OpenCL-CLHPP
that referenced
this pull request
Oct 2, 2024
Add `CL_DEVICE_COMMAND_BUFFER_SUPPORTED_QUEUE_PROPERTIES_KHR` from KhronosGroup/OpenCL-Docs#850
EwanC
added a commit
to EwanC/OpenCL-CTS
that referenced
this pull request
Oct 3, 2024
CTS test update to match OpenCL-Doc & OpenCL-Header PRs: * KhronosGroup/OpenCL-Headers#265 * KhronosGroup/OpenCL-Docs#850 Still in draft as i've not yet updated an implementation to verify these test changes
EwanC
added a commit
to EwanC/OpenCL-Headers
that referenced
this pull request
Oct 4, 2024
Updates to the command-buffer emulation layer to support changes from KhronosGroup/OpenCL-Docs#850 Requires using KhronosGroup#265 in `external/OpenCL-Headers` and can be used to test CTS changes from KhronosGroup/OpenCL-CTS#2101
EwanC
added a commit
to EwanC/SimpleOpenCLSamples
that referenced
this pull request
Oct 4, 2024
Updates to the command-buffer emulation layer to support changes from KhronosGroup/OpenCL-Docs#850 Requires using KhronosGroup/OpenCL-Headers#265 in `external/OpenCL-Headers` and can be used to test CTS changes from KhronosGroup/OpenCL-CTS#2101
EwanC
added a commit
to EwanC/SimpleOpenCLSamples
that referenced
this pull request
Oct 4, 2024
Updates to the command-buffer emulation layer to support changes from KhronosGroup/OpenCL-Docs#850 Requires using KhronosGroup/OpenCL-Headers#265 in `external/OpenCL-Headers` and can be used to test CTS changes from KhronosGroup/OpenCL-CTS#2101
EwanC
added a commit
to EwanC/OpenCL-CLHPP
that referenced
this pull request
Oct 9, 2024
Add `CL_DEVICE_COMMAND_BUFFER_SUPPORTED_QUEUE_PROPERTIES_KHR` from KhronosGroup/OpenCL-Docs#850
30 tasks
|
Looks ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new device query related to the command-buffer extension -
CL_DEVICE_COMMAND_BUFFER_SUPPORTED_QUEUE_PROPERTIES_KHR. This is different fromCL_DEVICE_COMMAND_BUFFER_REQUIRED_QUEUE_PROPERTIES_KHR, as we want to convey to the user that an implementation allows using a queue property with a command-buffer, but it is not mandatory to use the property with a command-buffer.This mechanism supersedes reporting queue related values from the
CL_DEVICE_COMMAND_BUFFER_CAPABILITIES_KHRquery. The flaw withCL_DEVICE_COMMAND_BUFFER_CAPABILITIES_KHRis that it contains bits explicitly added by the command-buffer extension for reporting support for queue properties. This is a brittle design, as any new queue property added in future would need to have a new bit added here in the command-buffer extension to report support when used with command-buffers.Instead, a better design is to have a new query reporting queue properties supported,
CL_DEVICE_COMMAND_BUFFER_SUPPORTED_QUEUE_PROPERTIES_KHR, and keepingCL_DEVICE_COMMAND_BUFFER_CAPABILITIES_KHRfor capabilities unrelated to the command-queue properties.The
CL_COMMAND_BUFFER_CAPABILITY_OUT_OF_ORDER_KHRuse-case can now be covered by returningCL_QUEUE_OUT_OF_ORDER_EXEC_MODE_ENABLEfromCL_DEVICE_COMMAND_BUFFER_SUPPORTED_QUEUE_PROPERTIES_KHR, so it is removed.Make
CL_QUEUE_PROFILING_ENABLEthe mandated minimum capability reported fromCL_DEVICE_COMMAND_BUFFER_SUPPORTED_QUEUE_PROPERTIES_KHR, to keep existing command-buffer extension requirement to implement profiling, which is inline with minimum requirements for host queues.Related OpenCL repo PRs: