allow clSetCommandQueueProperty to return an error for non-OpenCL 1.0 devices #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… devices This follows the same pattern and text used by clSetProgramReleaseCallback, which may return an error for non-OpenCL 2.2 devices.
alycm
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Returning an error is consistent with clSetProgramReleaseCallback.
I had a look at a few implementations and they generally return an error, or have some level of implementation that can return CL_SUCCESS.
The auto-generated version note still says "clSetCommandQueueProperty is deprecated by version 1.1." but I'm not immediately sure if cl.xml or the scripts around it have a concept of removal. I'd have to look at the XML for some other specifications.
I don't think the the previous paragraph is a blocker to merging this PR.
|
@kpet did you want to review this before merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #621
This follows the same pattern and text used by clSetProgramReleaseCallback, which may return an error for non-OpenCL 2.2 devices.