-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated CI, added CD #239
Updated CI, added CD #239
Conversation
3a74ccc
to
9496a83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am by no mean a CMake expert, the rest is looking good to me.
9496a83
to
864cbea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed in the April 9th teleconference. We just released specs v3.0.16 and we're planning a release for the headers shortly. We're going to hold off merging these changes until after the release, then we will plan to merge ASAP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging as discussed in the May 14th teleconference (and previously).
I'm seeing CI failures on my PR #251 which was opened after this merged, which look unrelated to the change i'm making In particular on macos gcc-11 configs I get the error (even after a retry):
Would somebody knowledgeable from this PR be able to help fix it. |
Tagging @mfep and perhaps @MathiasMagnus - see above. |
Yes, please see #252 |
-Werror
//WX
is enabled in CICMakeLists.txt
to be able to produce a binary Debian package usingcpack
.presubmit
workflow now.git-clang-format
.v*
tagDebSourcePkg.cmake
which is intended to run in CMake script mode. This script generates thedebian/control
,debian/changelog
and ``debian/rules` files which are required to build a Debian source package.This PR is considered to be complete, albeit review remarks and/or changes to related PRs might warrant minor updates.
The commits are authored by me, however a significant part of the work has been done by @Beanavil.